Skip to content

add default zip file name in dataframe to_csv when use 'infer' + 'zip' method #39647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

CyberQin
Copy link

@CyberQin CyberQin commented Feb 7, 2021

fix #39465

copy some code from gzip ,now df.to_csv('myfile.csv.zip') works like df.to_csv('myfile.csv.gz')

@pep8speaks
Copy link

pep8speaks commented Feb 7, 2021

Hello @HQDragon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-08 01:17:17 UTC

jorisvandenbossche and others added 17 commits February 8, 2021 09:16
Co-authored-by: JHM Darbyshire (iMac) <[email protected]>
@CyberQin
Copy link
Author

CyberQin commented Feb 8, 2021

sorry ,i messed up some git routine, i need to close this and open new one

@CyberQin CyberQin closed this Feb 8, 2021
@CyberQin CyberQin deleted the fix_zip_method_wrong_file_name branch February 8, 2021 01:34
@CyberQin
Copy link
Author

CyberQin commented Feb 8, 2021

pls review the new PR #39662
@twoertwein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame to_csv compression with 'zip' use zipfilename as archive name